SNOW-1271212 Fixed values uploaded to stage for bindings exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD #897
+454
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mhofman
force-pushed
the
SNOW-1271212-stage-binding-upload
branch
from
ff9c6b7 to
13e1320
Compare
sfc-gh-mhofman
force-pushed
the
SNOW-1271212-stage-binding-upload
branch
2 times, most recently
from
85efbeb to
bb491bb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #897 +/- ##
==========================================
+ Coverage 84.41% 84.70% +0.28%
==========================================
Files 89 89
Lines 9683 9681 -2
Branches 914 915 +1
==========================================
+ Hits 8174 8200 +26
+ Misses 1274 1253 -21
+ Partials 235 228 -7 ☔ View full report in Codecov by Sentry. |
sfc-gh-mhofman
force-pushed
the
SNOW-1271212-stage-binding-upload
branch
from
74be02f to
dd9879f
Compare
…IENT_STAGE_ARRAY_BINDING_THRESHOLD
…ARRAY_BINDING_THRESHOLD
sfc-gh-mhofman
force-pushed
the
SNOW-1271212-stage-binding-upload
branch
from
764b19a to
0e842c0
Compare
sfc-gh-pbulawa
approved these changes
Apr 3, 2024
sfc-gh-knozderko
approved these changes
Apr 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When number of binded values during query execution exceeds the threshold of a session parameter CLIENT_STAGE_ARRAY_BINDING_THRESHOLD then values are written as a CSV file to a stage and it get's picked during query excecution.
Improper values (or values truncating fractions of ms) has been uploaded for date and time related columns of type: DATE, TIME, TIMESTAMP_LTZ, TIMESTAMP_NTZ, TIMESTAMP_TZ.
Checklist
dotnet test)